Card tool rows collapse through one ToolRow
卡片工具行通过同一个 ToolRow 折叠
The Web client grew five card render intents over successive PRs — terminal, diff, read, search, web — each landing as a keyed toolview registrant under `packages/client/ui-conversation/src/client/toolviews/`. They diverged in two ways the earlier PRs each acknowledged but deferred: - **Chrome duplication.** `read-row`, `search-row`, `web-row`, and `file-mutation-row` each hand-drew the summary row (leading state slo
English
Problem
The Web client grew five card render intents over successive PRs — terminal, diff, read, search, web — each landing as a keyed toolview registrant under packages/client/ui-conversation/src/client/toolviews/. They diverged in two ways the earlier PRs each acknowledged but deferred:
- Chrome duplication.
read-row,search-row,web-row, andfile-mutation-roweach hand-drew the summary row (leading state slot, visually-hidden status, title, separator dot, path-link/summary) as their own<div className={css.root}>with a private.module.css, instead of composing the sharedToolRow.read-rowcarried ajscpd:ignoremarker naming the duplication and pointing at "a separate change tracked for all rows at once" — this change. - Resident vs. collapsed. Those four rows kept their card (
ReadBlock/SearchBlock/WebBlock/DiffBlock) resident below the summary — always expanded — while the terminal card (viaGenericToolCard/BashRow) and every text row started collapsed behind ToolRow's whole-row expand. A conversation with several read/search/web/edit calls became a wall of always-open cards, defeating the summary-surface purpose of the message flow.
Decision
ToolRow owns every card kind, and every keyed card row composes it. ToolRow already took terminal and diff card material; it now also takes read, search, and web, rendering whichever is present in its collapsed-by-default expanded body through the matching primitive (capped at the chat CHAT_* bounds). A call carries at most one card kind, so the props are mutually exclusive and the body picks the first present.
The four keyed rows — ReadRow, SearchRow, WebRow, FileMutationRow — drop their hand-drawn chrome and private CSS and become thin ToolRow compositions, exactly like AskQuestionRow: derive the card model, pass it as the matching ToolRow prop, forward filePath/onOpenFile for the file tools and output/errorSummary for the cardless failure paths. Each row is now ToolRowProps & PropsLocale<'conversation'> and registers with locale: NS, because ToolRow needs the conversation t for its terminal/code body copy. GenericToolCard (the render-site fallback) does the same for read/search/web, so a card-declaring tool without its own keyed row collapses identically.
The DetailsPanel Output section is unchanged: the panel is the single-call reading surface, so it renders each card resident at the primitive's full height, and a capped search keeps its recovery footer there.
Consequences
- One expand interaction across all tool rows: collapsed one-line summary, whole row toggles the card. The card is not in the DOM until expanded (
DisclosureRowrenderschildrenonly when open), so tests assert absent-then-present around a[data-expandable]click. - Deleted:
read-row.module.css,search-row.module.css,web-row.module.css,file-mutation-row.module.css,GenericToolCard.module.css. The rows carry no CSS of their own; ToolRow's module owns the chrome and the card-body indentation. - The cardless failure paths (an errored mutation, an errored/nested/legacy search) no longer draw their own
.failure/recovery<div>; they ride ToolRow'soutput(Output section) anderrorSummary(collapsed summary first line), which already flatten the result text with theerror.name: error.codefallback. bash-samplekeeps its own local expand chrome deliberately (the third-party-posture exemplar that never imports the chat domain); it was already collapsed, so its behavior is unchanged.
Alternatives considered
- Keep the rows resident, only unify chrome. Rejected: the user's requirement is default-collapsed, and resident cards are what made the flow unscannable.
- A shared
CardRowwrapper between the rows and ToolRow. Rejected: ToolRow already is that wrapper once it takes every card kind; a second layer would be the premature extraction the package rules warn against.
中文
问题
Web 客户端在连续几个 PR 里长出五种卡片渲染意图——terminal、diff、read、search、web，每一种都作为一个键控 toolview 注册项落在 packages/client/ui-conversation/src/client/toolviews/ 下。它们在两处出现分歧，之前每个 PR 都承认却推迟处理：
- Chrome 重复。
read-row、search-row、web-row、file-mutation-row各自把摘要行（行首状态槽、视觉隐藏状态、标题、分隔点、路径链接/摘要）手绘成自己的<div className={css.root}>，配一份私有.module.css，而不是组合共享的ToolRow。read-row带着一个jscpd:ignore标记，点名这处重复并指向"一处针对所有行一次性处理的独立改动"——就是本次改动。 - 常驻 vs 折叠。 那四个行把卡片（
ReadBlock/SearchBlock/WebBlock/DiffBlock）常驻在摘要下方——始终展开——而终端卡片（经GenericToolCard/BashRow）与每个文本行都从折叠状态起步，藏在 ToolRow 的整行展开之后。一个有多个 read/search/web/edit 调用的对话就成了一堵始终打开的卡片墙，违背了消息流作为摘要面的目的。
决策
ToolRow 拥有每一种卡片，而每个键控卡片行都组合它。ToolRow 原本就接收 terminal 与 diff 卡片材料；现在还接收 read、search、web，在其默认折叠的展开 body 里用对应原语渲染当前存在的那一种（按 chat 的 CHAT_* 上限截断）。一次调用最多携带一种卡片，因此这些 prop 互斥，body 取第一个存在的。
四个键控行——ReadRow、SearchRow、WebRow、FileMutationRow——丢掉手绘 chrome 与私有 CSS，成为薄薄的 ToolRow 组合，与 AskQuestionRow 完全一样：推导卡片模型，作为对应的 ToolRow prop 传入，为文件工具转发 filePath/onOpenFile，为无卡片的失败路径转发 output/errorSummary。每个行现在是 ToolRowProps & PropsLocale<'conversation'> 并以 locale: NS 注册，因为 ToolRow 需要对话的 t 来渲染其终端/代码 body 文案。GenericToolCard（渲染点兜底）对 read/search/web 做同样的事，所以一个没有自己键控行的卡片声明工具也以同样方式折叠。
DetailsPanel 的 Output 区不变：面板是单次调用的阅读面，因此它以原语的完整高度常驻渲染每张卡片，被截断的搜索也把恢复脚注留在那里。
后果
- 所有工具行共享一套展开交互：折叠时是单行摘要，整行切换卡片。卡片在展开前不在 DOM 里（
DisclosureRow只在打开时渲染children），因此测试围绕一次[data-expandable]点击断言"先无后有"。 - 已删除：
read-row.module.css、search-row.module.css、web-row.module.css、file-mutation-row.module.css、GenericToolCard.module.css。这些行不再带自己的 CSS；ToolRow 的 module 拥有 chrome 与卡片 body 的缩进。 - 无卡片的失败路径（出错的改动，出错/嵌套/旧日志的搜索）不再画自己的
.failure/恢复<div>；它们改走 ToolRow 的output（Output 区）与errorSummary（折叠摘要首行），后者已经用error.name: error.code兜底压平结果文本。 bash-sample有意保留自己本地的展开 chrome（第三方姿态的范例，从不引入 chat 域）；它本来就是折叠的，因此行为不变。
考虑过的替代方案
- 保持行常驻，只统一 chrome。 否决：用户的要求是默认折叠，而常驻卡片正是让流不可扫读的原因。
- 在行与 ToolRow 之间加一层共享的
CardRow包装。 否决：ToolRow 一旦接收每一种卡片，它本身就是那层包装；再加一层就是 package 规则警告的过早抽取。